From c883ced12f51fc9b81dd0b7955bf4d23ccf9238b Mon Sep 17 00:00:00 2001 From: Nick Gasson Date: Sun, 5 Sep 2010 11:41:13 +0100 Subject: [PATCH] Don't ignore the return value of asprintf --- src/config_file.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/config_file.c b/src/config_file.c index 461748f..c351045 100644 --- a/src/config_file.c +++ b/src/config_file.c @@ -173,10 +173,12 @@ static char *config_file_name(void) const char *xdg_config_home = getenv("XDG_CONFIG_HOME"); if (xdg_config_home == NULL || *xdg_config_home == '\0') { // Defaults to $HOME/.config - asprintf(&fname, "%s/.config/xcowsayrc", home); + if (asprintf(&fname, "%s/.config/xcowsayrc", home) == -1) + return NULL; } else - asprintf(&fname, "%s/xcowsayrc", xdg_config_home); + if (asprintf(&fname, "%s/xcowsayrc", xdg_config_home) == -1) + return NULL; struct stat dummy; if (stat(fname, &dummy) == 0) @@ -185,7 +187,9 @@ static char *config_file_name(void) free(fname); // Try the home directory - asprintf(&fname, "%s/.xcowsayrc", home); + if (asprintf(&fname, "%s/.xcowsayrc", home) == -1) + return NULL; + if (stat(fname, &dummy) == 0) return fname; -- 2.39.2